Facilitate customization of setupTest* functions

[kategengler]

Rendered

[rwjblue]

Thank you for writing this @kategengler! I am strongly in favor of this proposal.

[ro0gr]

What would be an import path within addons?

Is it an absolute path:

import setupTest from 'dummy/tests/helpers';

Or relative:

import setupTest from '../tests/helpers';

[jgwhite]

This is terrific. It seems plausible that addons could use this new convention to add their setup* functions automatically when installed. For example, ember install ember-cli-mirage could codemod tests/helpers/index.js as follows:

  import { setupApplicationTest as upstreamSetupApplicationTest } from 'ember-qunit';
+ import { setupMirage } from 'ember-cli-mirage/test-support';
  export function setupApplicationTest(hooks, options) {
    upstreamSetupApplicationTest(hooks, options);
+   setupMirage(hooks);
    // customize here
  }
  export { setupTest, setupRenderingTest } from 'ember-qunit';

[rwjblue]

@jgwhite

This is terrific. It seems plausible that addons could use this new convention to add their setup* functions automatically when installed. For example, ember install ember-cli-mirage could codemod tests/helpers/index.js as follows...

Yes, exactly.

[rwjblue]

@ro0gr

What would be an import path within addons?

It would be absolute.

[kategengler]

We discussed this in today's framework meeting and are moving it into Final Comment Period.

[sandstrom]

@kategengler This would be very useful! 💯

[rwjblue]

🎉

[lougreenwood]

Are there any plans for implementing this?

We adopted this format for our project about 6 months ago, but the burden of updating the imports for generated tests is beginning to get annoying. We're considering whether to just update our local blueprints or possibly chip in on the RFC implementation if it isn't too complex.

[rwjblue]

Are there any plans for implementing this?

As far as I know, this hasn't been started by anyone. I don't think the specific implementation is terribly difficult (though perhaps there is something we missed in the initial design), and I'd be happy to help guide you through the steps if you want to pick it up (just ping me in discord).

[bertdeblock]

@lougreenwood I have been working on this. The corresponding PRs are listed above.