Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable order-in-* rules by default #173

Merged
merged 1 commit into from
Nov 15, 2017
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -111,10 +111,10 @@ The `--fix` option on the command line automatically fixes problems reported by

| | Rule ID | Description |
|:---|:--------|:------------|
| :white_check_mark: | [order-in-components](./docs/rules/order-in-components.md) | Enforces proper order of properties in components |
| :white_check_mark: | [order-in-controllers](./docs/rules/order-in-controllers.md) | Enforces proper order of properties in controllers |
| :white_check_mark: | [order-in-models](./docs/rules/order-in-models.md) | Enforces proper order of properties in models |
| :white_check_mark: | [order-in-routes](./docs/rules/order-in-routes.md) | Enforces proper order of properties in routes |
| | [order-in-components](./docs/rules/order-in-components.md) | Enforces proper order of properties in components |
| | [order-in-controllers](./docs/rules/order-in-controllers.md) | Enforces proper order of properties in controllers |
| | [order-in-models](./docs/rules/order-in-models.md) | Enforces proper order of properties in models |
| | [order-in-routes](./docs/rules/order-in-routes.md) | Enforces proper order of properties in routes |
| :white_check_mark: | [use-brace-expansion](./docs/rules/use-brace-expansion.md) | Enforces usage of brace expansion |

### Deprecated
Expand Down
8 changes: 4 additions & 4 deletions lib/recommended-rules.js
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ module.exports = {
"ember/no-old-shims": "error",
"ember/no-on-calls-in-components": "error",
"ember/no-side-effects": "error",
"ember/order-in-components": "error",
"ember/order-in-controllers": "error",
"ember/order-in-models": "error",
"ember/order-in-routes": "error",
"ember/order-in-components": "off",
"ember/order-in-controllers": "off",
"ember/order-in-models": "off",
"ember/order-in-routes": "off",
"ember/require-super-in-init": "error",
"ember/routes-segments-snake-case": "error",
"ember/use-brace-expansion": "error",
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/order-in-components.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ module.exports = {
docs: {
description: 'Enforces proper order of properties in components',
category: 'Stylistic Issues',
recommended: true
recommended: false
},
fixable: null // or "code" or "whitespace"
},
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/order-in-controllers.js
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ module.exports = {
docs: {
description: 'Enforces proper order of properties in controllers',
category: 'Stylistic Issues',
recommended: true
recommended: false
},
fixable: null, // or "code" or "whitespace"
},
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/order-in-models.js
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ module.exports = {
docs: {
description: 'Enforces proper order of properties in models',
category: 'Stylistic Issues',
recommended: true
recommended: false
},
fixable: null, // or "code" or "whitespace"
},
Expand Down
2 changes: 1 addition & 1 deletion lib/rules/order-in-routes.js
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ module.exports = {
docs: {
description: 'Enforces proper order of properties in routes',
category: 'Stylistic Issues',
recommended: true
recommended: false
},
fixable: null // or "code" or "whitespace"
},
Expand Down
4 changes: 0 additions & 4 deletions tests/__snapshots__/recommended.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -16,10 +16,6 @@ Array [
"no-old-shims",
"no-on-calls-in-components",
"no-side-effects",
"order-in-components",
"order-in-controllers",
"order-in-models",
"order-in-routes",
"require-super-in-init",
"routes-segments-snake-case",
"use-brace-expansion",
Expand Down