Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nyan reporter in CI #9

Merged
merged 2 commits into from
Feb 4, 2017

Conversation

alexlafroscia
Copy link
Contributor

Cute as it locally, the output on Travis isn't very useful.

@alexlafroscia
Copy link
Contributor Author

Do you all have Travis disabled for pull-requests? I don't see the build on here:

https://travis-ci.org/netguru/eslint-plugin-ember/pull_requests

I was banking on using that to ensure that the change actually worked.

"test": "mocha tests --recursive --reporter nyan",
"start": "mocha tests --recursive --reporter nyan --watch"
"test:ci": "mocha tests --recursive"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could also do some yarn-foo here to reduce the repetition:

{
  "scripts": {
    "start": "yarn test -- --watch",
    "test": "yarn test:ci -- --reporter nyan",
    "test:ci": "mocha tests --recursive"
  }
}

but yarn then prints the little thing that looks like

yarn test:ci v0.19.1
$ mocha tests --recursive

for each of the invocations, which is a little messy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not a big deal having this little repetition here. Keeping things simple stupid has it's benefits too :)

@michalsnik
Copy link
Member

Hey @alexlafroscia. It seems reasonable. We had enabled travis per request (https://travis-ci.org/netguru/eslint-plugin-ember/requests) but not per PR, I switched that now so you can push an empty commit to trigger build. Let's see how this works.

@michalsnik michalsnik merged commit 8a04235 into ember-cli:master Feb 4, 2017
@michalsnik
Copy link
Member

Thanks for the contribution @alexlafroscia ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants