Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable nyan reporter in CI #9

Merged
merged 2 commits into from
Feb 4, 2017
Merged

Disable nyan reporter in CI #9

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4c3a8d
Disable nyan reporter in CI
alexlafroscia Jan 27, 2017
a4d7d37
Triggering Travis build for PR
alexlafroscia Jan 30, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,3 +4,5 @@ node_js:
- '6.3'

cache: yarn

script: yarn test:ci
3 changes: 2 additions & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@
"test": "test"
},
"scripts": {
"start": "mocha tests --recursive --reporter nyan --watch",
"test": "mocha tests --recursive --reporter nyan",
"start": "mocha tests --recursive --reporter nyan --watch"
"test:ci": "mocha tests --recursive"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could also do some yarn-foo here to reduce the repetition:

{
  "scripts": {
    "start": "yarn test -- --watch",
    "test": "yarn test:ci -- --reporter nyan",
    "test:ci": "mocha tests --recursive"
  }
}

but yarn then prints the little thing that looks like

yarn test:ci v0.19.1
$ mocha tests --recursive

for each of the invocations, which is a little messy.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's not a big deal having this little repetition here. Keeping things simple stupid has it's benefits too :)

},
"repository": {
"type": "git",
Expand Down