Skip to content

Apply website redesign rfc styles #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Nov 3, 2019

The goal of this PR is to minimally apply the website redesign styles found in ember-styleguide (ember-learn/ember-styleguide#145)

It aims to remove more CSS than it adds, and serve as a blank canvas to apply more advanced styles to after initial launch.

Changed

  • colors to match the styleguide
  • use grid system for sidebar layout

Removed

  • a lot of CSS that could be replaced by utility classes

Needs work to reach MVP

  • default link color is not accessible for regular sized text
  • The search dropdowns need a lot of work, probably.
  • Does nav work in fastboot?
  • Needs clearer visual divisions between API methods
  • Why is the navbar squished?

Screenshots

Screen Shot 2019-11-02 at 9 10 42 PM

Screen Shot 2019-11-02 at 9 10 54 PM

Screen Shot 2019-11-02 at 9 11 29 PM

@locks locks temporarily deployed to ember-api-docs-review-t-pr-645 February 24, 2020 21:35 Inactive
@sivakumar-kailasam sivakumar-kailasam temporarily deployed to ember-api-docs-review-t-pr-645 February 24, 2020 21:59 Inactive
@locks locks temporarily deployed to ember-api-docs-review-t-pr-645 March 7, 2020 00:17 Inactive
@sivakumar-kailasam sivakumar-kailasam temporarily deployed to ember-api-docs-review-t-pr-645 March 7, 2020 18:16 Inactive
@sivakumar-kailasam sivakumar-kailasam temporarily deployed to ember-api-docs-review-t-pr-645 March 8, 2020 15:37 Inactive
@sivakumar-kailasam sivakumar-kailasam temporarily deployed to ember-api-docs-review-t-pr-645 March 8, 2020 15:57 Inactive
@sivakumar-kailasam sivakumar-kailasam temporarily deployed to ember-api-docs-review-t-pr-645 March 8, 2020 16:37 Inactive
@sivakumar-kailasam sivakumar-kailasam temporarily deployed to ember-api-docs-review-t-pr-645 March 8, 2020 17:13 Inactive
@sivakumar-kailasam sivakumar-kailasam temporarily deployed to ember-api-docs-review-t-pr-645 March 8, 2020 17:31 Inactive
@sivakumar-kailasam sivakumar-kailasam temporarily deployed to ember-api-docs-review-t-pr-645 March 8, 2020 20:58 Inactive
@sivakumar-kailasam sivakumar-kailasam temporarily deployed to ember-api-docs-review-t-pr-645 March 9, 2020 01:50 Inactive
@locks locks temporarily deployed to ember-api-docs-review-t-pr-645 March 28, 2020 05:46 Inactive
@Gaurav0
Copy link
Contributor

Gaurav0 commented Mar 30, 2020

@sivakumar-kailasam @jenweber I'd really like to see this land rather than keep it open for a very long period of time. Is there anything I can do to help?

@sivakumar-kailasam
Copy link
Member

We have some design mocks for this app. I'll add them here later today & list items that need to be addressed that contributors can work on.

Due to the nature of the work involved, this branch will be long lived until we're ready to launch. We'll have to start creating PRs against this branch similar to what we did on the ember-wesbite repo until then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants