Skip to content

Commit

Permalink
Merge pull request #925 from loganrosen/ember-3.25
Browse files Browse the repository at this point in the history
Update to ember-cli 3.25 blueprint
  • Loading branch information
ijlee2 authored Mar 10, 2021
2 parents 1254593 + 607e4a8 commit b6c111e
Show file tree
Hide file tree
Showing 19 changed files with 5,231 additions and 5,146 deletions.
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# misc
/coverage/
!.*
.eslintcache

# ember-try
/.node_modules.ember-try/
Expand Down
28 changes: 14 additions & 14 deletions .eslintrc.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,47 +7,47 @@ module.exports = {
ecmaVersion: 2018,
sourceType: 'module',
ecmaFeatures: {
legacyDecorators: true
}
legacyDecorators: true,
},
},
plugins: [
'ember'
],
plugins: ['ember'],
extends: [
'eslint:recommended',
'plugin:ember/recommended'
'plugin:ember/recommended',
'plugin:prettier/recommended',
],
env: {
browser: true
browser: true,
},
rules: {},
overrides: [
// node files
{
files: [
'.eslintrc.js',
'.prettierrc.js',
'.template-lintrc.js',
'ember-cli-build.js',
'testem.js',
'blueprints/*/index.js',
'config/**/*.js',
'lib/*/index.js',
'server/**/*.js'
'server/**/*.js',
],
parserOptions: {
sourceType: 'script'
sourceType: 'script',
},
env: {
browser: false,
node: true
node: true,
},
plugins: ['node'],
extends: ['plugin:node/recommended'],
rules: {
// this can be removed once the following is fixed
// https://github.com/mysticatea/eslint-plugin-node/issues/77
'node/no-unpublished-require': 'off'
}
}
]
'node/no-unpublished-require': 'off',
},
},
],
};
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
/.env*
/.pnp*
/.sass-cache
/.eslintcache
/connect.lock
/coverage/
/libpeerconnection.log
Expand Down
21 changes: 21 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# unconventional js
/blueprints/*/files/
/vendor/

# compiled output
/dist/
/tmp/

# dependencies
/bower_components/
/node_modules/

# misc
/coverage/
!.*
.eslintcache

# ember-try
/.node_modules.ember-try/
/bower.json.ember-try
/package.json.ember-try
5 changes: 5 additions & 0 deletions .prettierrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
'use strict';

module.exports = {
singleQuote: true,
};
2 changes: 1 addition & 1 deletion .template-lintrc.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
'use strict';

module.exports = {
extends: 'octane'
extends: 'octane',
};
3 changes: 1 addition & 2 deletions app/router.js
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,4 @@ export default class Router extends EmberRouter {
rootURL = config.rootURL;
}

Router.map(function() {
});
Router.map(function () {});
1 change: 0 additions & 1 deletion app/routes/application.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import EmpressApplicationRoute from 'empress-blog/routes/application';
import { inject as service } from '@ember/service';


export default class ApplicationRoute extends EmpressApplicationRoute {
@service metrics;
@service router;
Expand Down
4 changes: 3 additions & 1 deletion app/routes/page.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ export default class PageRoute extends Route {
templateName = 'index';

model(params) {
return this.store.query('content', {page: `/content/content-${params.id}.json`});
return this.store.query('content', {
page: `/content/content-${params.id}.json`,
});
}
}
2 changes: 1 addition & 1 deletion config/ember-cli-update.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"packages": [
{
"name": "ember-cli",
"version": "3.21.2",
"version": "3.25.2",
"blueprints": [
{
"name": "app",
Expand Down
14 changes: 7 additions & 7 deletions config/environment.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use strict';

module.exports = function(environment) {
module.exports = function (environment) {
let ENV = {
modulePrefix: 'ember-blog',
environment,
Expand All @@ -14,8 +14,8 @@ module.exports = function(environment) {
},
EXTEND_PROTOTYPES: {
// Prevent Ember Data from overriding Date.parse.
Date: false
}
Date: false,
},
},

APP: {
Expand All @@ -27,8 +27,8 @@ module.exports = function(environment) {
title: 'Ember.js Blog',
description: 'Official Blog for the Ember.js Open Source Project',
paginate: true,
logo: "/images/logos/e-icon.png",
twitter: "emberjs",
logo: '/images/logos/e-icon.png',
twitter: 'emberjs',
},

metricsAdapters: [
Expand All @@ -37,8 +37,8 @@ module.exports = function(environment) {
environments: ['production'],
config: {
id: 'UA-27675533-1',
require: ['linkid']
}
require: ['linkid'],
},
},
],
};
Expand Down
4 changes: 2 additions & 2 deletions config/targets.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const browsers = [
'last 1 Chrome versions',
'last 1 Firefox versions',
'last 1 Safari versions'
'last 1 Safari versions',
];

const isCI = Boolean(process.env.CI);
Expand All @@ -15,5 +15,5 @@ if (isCI || isProduction) {

module.exports = {
browsers,
node: 'current'
node: 'current',
};
Loading

0 comments on commit b6c111e

Please sign in to comment.