Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ember-cli 3.25 blueprint #925

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Conversation

loganrosen
Copy link

I've used ember-cli-update to update ember-blog to the ember-cli 3.25 blueprint.

I've used ember-cli-update to update ember-blog to the ember-cli 3.25
blueprint.
package.json Outdated Show resolved Hide resolved
"ember-resolver": "^8.0.2",
"ember-source": "~3.21.1",
"ember-template-lint": "^2.11.0",
"ember-source": "~3.25.1",
Copy link
Member

@ijlee2 ijlee2 Mar 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure yet why Netlify deploy for your pull request failed. I don't think this will make a change, but could you update to the latest ember-source, which is 3.25.3?

Suggested change
"ember-source": "~3.25.1",
"ember-source": "~3.25.3",

If ember-cli-update wasn't able to get the latest patch version yet, I think you can manually update the patch version in package.json and in config/ember-cli-update.json.

Afterwards, install packages locally to create a new lockfile, then commit the 3 files.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found emberjs/data#7361, which indicates that this is due to caching behavior, and it is necessary to wipe away node_modules for the build to succeed again. I'm not sure the exact caching behavior that Netlify has/how to address that, though.

Regarding the ember-source version, ~3.25.1 actually resolves to 3.25.3 in package-lock.json, so this PR is pulling in the latest version regardless.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a project maintainer, would you be able to retry the deploy with a cleared cache as described here?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. Yep, I can definitely help with deploying after clearing cache.

Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@loganrosen Thank you for taking time to update the ember-blog app to use the latest Ember! I left a couple of requests before we try again to see if Netlify deploy will succeed. Could you have a look?

Copy link
Member

@ijlee2 ijlee2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deploy success! 🎉

@ijlee2 ijlee2 merged commit b6c111e into ember-learn:master Mar 10, 2021
@loganrosen loganrosen deleted the ember-3.25 branch March 10, 2021 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants