-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to ember-cli 3.25 blueprint #925
Conversation
I've used ember-cli-update to update ember-blog to the ember-cli 3.25 blueprint.
"ember-resolver": "^8.0.2", | ||
"ember-source": "~3.21.1", | ||
"ember-template-lint": "^2.11.0", | ||
"ember-source": "~3.25.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure yet why Netlify deploy for your pull request failed. I don't think this will make a change, but could you update to the latest ember-source
, which is 3.25.3?
"ember-source": "~3.25.1", | |
"ember-source": "~3.25.3", |
If ember-cli-update
wasn't able to get the latest patch version yet, I think you can manually update the patch version in package.json
and in config/ember-cli-update.json
.
Afterwards, install packages locally to create a new lockfile, then commit the 3 files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found emberjs/data#7361, which indicates that this is due to caching behavior, and it is necessary to wipe away node_modules
for the build to succeed again. I'm not sure the exact caching behavior that Netlify has/how to address that, though.
Regarding the ember-source
version, ~3.25.1
actually resolves to 3.25.3
in package-lock.json
, so this PR is pulling in the latest version regardless.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As a project maintainer, would you be able to retry the deploy with a cleared cache as described here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah. Yep, I can definitely help with deploying after clearing cache.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loganrosen Thank you for taking time to update the ember-blog
app to use the latest Ember! I left a couple of requests before we try again to see if Netlify deploy will succeed. Could you have a look?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Deploy success! 🎉
I've used
ember-cli-update
to updateember-blog
to theember-cli
3.25 blueprint.