Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename ENABLE_ALL_FEATURES flag to ENABLE_OPTIONAL_FEATURES for versions v2.3.0 and up #1824

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Rename ENABLE_ALL_FEATURES flag to ENABLE_OPTIONAL_FEATURES for versions v2.3.0 and up #1824

merged 1 commit into from
Sep 7, 2022

Conversation

bertdeblock
Copy link
Contributor

The ENABLE_ALL_FEATURES flag was removed in v2.3.0 in favour of ENABLE_OPTIONAL_FEATURES:
emberjs/ember.js#12627

Copy link
Contributor

@locks locks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it touches quite old versions, we will have to re-compile them. I think we should do this, but I'm marking as changes requested so someone doesn't accidentally merge this and we forget to precompile the old versions.
@mansona can you provide some guidance on how to do it?

@bertdeblock
Copy link
Contributor Author

@locks Is re-compiling the older versions something we still want to do?

@bertdeblock
Copy link
Contributor Author

bertdeblock commented Sep 7, 2022

Can we merge this and create a separate issue for re-compiling the older versions?

EDIT:

I missed this:

Please note that no attempt is made to update content for older versions of the Guides. Except for broken links, they are considered static and immutable, as it is too difficult to maintain content for every version ever released. Issues will only be fixed for future releases.

I can also just revert the changes for the older versions.

@locks
Copy link
Contributor

locks commented Sep 7, 2022

sure

@locks locks merged commit b3fff8a into ember-learn:master Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants