[CLEANUP beta] #12627
Merged
[CLEANUP beta] #12627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
packages/ember-views/lib/views/view.js is failing JSHint ( |
Remove unused ENV flags, this is just to keep PRs small, this is part of a fix for Mixin that went into beta. ENABLE_ALL_FEATURES can't actually do anything more than ENABLE_OPTIONAL_FEATURES, other features are always build time. SHIM_ES5 is just unused as is DISABLE_RANGE_API
rwjblue
force-pushed
the
remove-unused-flag
branch
from
cf56d10
to
9591917
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unused ENV flags, this is just to keep PRs small, this is part of a fix for Mixin that went into beta.
ENABLE_ALL_FEATURES can't actually do anything more than ENABLE_OPTIONAL_FEATURES, other features are always build time.
SHIM_ES5 is just unused as is DISABLE_RANGE_API