Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tutorial #2000

Merged
merged 16 commits into from
Feb 29, 2024
Merged

Fix tutorial #2000

merged 16 commits into from
Feb 29, 2024

Conversation

mansona
Copy link
Member

@mansona mansona commented Jan 29, 2024

This PR adds a little script that I used to update the tutorial and I ran it to get the diffs for us.

Things to do before we merge this:

  • either manually or automatically update the external links from each version to the correct ember/ember-data versions
  • generally double check this works 🤷
  • any other things?

Copy link

netlify bot commented Jan 29, 2024

Deploy Preview for ember-guides ready!

Name Link
🔨 Latest commit 1622395
🔍 Latest deploy log https://app.netlify.com/sites/ember-guides/deploys/65df380dd97fde0007f49e26
😎 Deploy Preview https://deploy-preview-2000--ember-guides.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mansona mansona force-pushed the fix-tutorial branch 2 times, most recently from 1983558 to b8fbde6 Compare February 26, 2024 16:47
@mansona mansona marked this pull request as ready for review February 26, 2024 16:59
update-tutorial.mjs Outdated Show resolved Hide resolved
update-tutorial.mjs Outdated Show resolved Hide resolved
@IgnaceMaes
Copy link
Member

Could we have a short description and example usage of the script, if it gets included in source control?

@mansona
Copy link
Member Author

mansona commented Feb 28, 2024

sorry something wasn't clear with this PR 🙈 the actual script isn't intended to be used in the future, I only included it in the PR to make sure that we didn't lose the code. I've removed it now as the last commit 👍

package.json Outdated Show resolved Hide resolved
Copy link
Member

@IgnaceMaes IgnaceMaes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did some quick spot checks on links and LGTM.

@mansona mansona merged commit 45264aa into master Feb 29, 2024
4 checks passed
@mansona mansona deleted the fix-tutorial branch February 29, 2024 16:06
@mansona mansona mentioned this pull request Feb 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants