Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unnecessary mentions of RSVP #546

Merged
merged 2 commits into from
Mar 1, 2019
Merged

remove unnecessary mentions of RSVP #546

merged 2 commits into from
Mar 1, 2019

Conversation

locks
Copy link
Contributor

@locks locks commented Mar 1, 2019

Closes #237.

@ppcano can you 👀?

@ppcano
Copy link
Contributor

ppcano commented Mar 1, 2019

@locks

Ack "rsvp" guides/release/ still shows a few places where RSVP is referenced.

guides/release/configuring-ember/debugging.md
123:import RSVP from 'rsvp';

guides/release/contributing/repositories.md
58:* **rsvp.js** - Implementation of the of Promises/A+ spec used by Ember.
59:* [https://github.com/tildeio/rsvp.js](https://github.com/tildeio/rsvp.js)

guides/release/routing/asynchronous-routing.md
57:take a look at the readme for [RSVP](https://github.com/tildeio/rsvp.js),

guides/release/routing/specifying-a-routes-model.md
125:[RSVP.hash](https://www.emberjs.com/api/ember/release/classes/rsvp/methods/hash?anchor=hash).
131:import RSVP from 'rsvp';
214:import RSVP from 'rsvp';

In this Discuss post, there are two examples on how the RSVP.hash method could be refactored.

Thank you for working on this one.

@locks
Copy link
Contributor Author

locks commented Mar 1, 2019

@ppcano I purposefully left those references because they seemed to make sense in context.

In the debugging section, it's talking about debugging RSVP promises.
Since RSVP has been recommended for a while and is still provided by default, it seems better to leave the prose in place.

The repositories reference was left for mostly the same reason. It is part of the default stack.
Another reasons for leaving it alone is that there is an (RFC for improving the Contributing guides)[https://github.com/emberjs/rfcs/pull/446].

I kept RSVP.hash because I think it is cleaner and less error prone than the refactorings.

I've removed the mention in the async routing guide!

@ppcano
Copy link
Contributor

ppcano commented Mar 1, 2019

@locks As feedback, I would remove RSVP.hash but I see your point.

LGTM

@locks locks requested a review from a team March 1, 2019 12:08
Copy link
Member

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@MelSumner MelSumner merged commit cc56af6 into master Mar 1, 2019
@locks locks deleted the rsvp branch March 9, 2019 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants