Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contribution Guides #446

Merged
merged 2 commits into from
Mar 10, 2019
Merged

Conversation

jayjayjpg
Copy link
Member

@jayjayjpg jayjayjpg commented Feb 14, 2019

@rwjblue
Copy link
Member

rwjblue commented Feb 14, 2019

Sounds awesome to me!

@MelSumner
Copy link
Contributor

This is great work, thank you for making this idea happen! 👍

@kennethlarsen
Copy link
Member

This is such a great idea - I'm really looking forward to this.

@jrjohnson
Copy link

Another possible source of inspiration https://www.nodetodo.org/

@MelSumner
Copy link
Contributor

The Learning Core Team has reached consensus to move this to Final Comment Period.

@ppcano
Copy link

ppcano commented Mar 1, 2019

Recently, I have started to contribute more often and I have experienced some of the issues this RFC is improving. Love the idea and it would be very useful.

I will share some random feedback without going deeper into the details:

1 - Adding a section describing common type of welcome contributions:

  • Small typos or correction: small PRs does not exist.

  • Improve docs

  • Search new issues on the Help wanted app.

  • Specific areas: marketing, community...

  • Jump into ongoing initiatives under the Status Board page.

  • Help maintaining existing projects

  • ...

2 - General tips for contributing from a newcomer’s perspective

This is likely already included on the Topics section, but I find interesting to describe more about general tips to focus not only on the first contribution but the long term.

Very good to help with "tips for the review process about finding a reviewer”. I think it also depends on the organization aspects of the community.

@jenweber jenweber self-requested a review March 7, 2019 16:50
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that you have a few things in "Unresolved Questions" about the exact form that this content should take, but I think we should merge this RFC as soon as possible and start working together to figure out how to make this a reality 🎉

Should the Guides be expanded by relevant information about other types of contribution work as we iterate on it?

I think that this RFC clearly communicates an intent to make the on-ramp for contributing to Ember in any way much easier for any level of developer. I think that eventually expending the Guide to include non-code related contributions is already captured in the spirit of this RFC 👍

@jayjayjpg
Copy link
Member Author

The Ember Learning Core team has reached consensus to merge this RFC and kick off the work for the Contribution Guides. A huge thank you goes to everyone who took the time to read and comment on the proposal! ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants