Dependency Injections are broken when using ember 2.12 and newer.

[workmanw]

Originally filed as: emberjs/ember.js#14941
Ember-Release (2.11.x): Working Twiddle
Ember-Beta (2.12.x): Broken Twiddle

It seems that using owner.inject targeting a model type is broken w/ ember-beta. Example:

// app/initializers/i18n.js
export default {
  name: 'i18n',
  after: 'ember-i18n',
  initialize: function(app) {
    app.inject('model', 'i18n', 'service:i18n')
  }
};

Additionally, other ember types, such as component and controller, work as expected.

---

@rwjblue helped me on slack to track this down a bit. We believe the cause of the problem lies with the implementation of modelForFactory (store#modelForFactory).

Prior to Ember 2.11, ember-data used _lookupFactory and internally that would do all of the dependency injections via an expensive .extend() process. One benefit of factoryFor is that it does not do this and thus saves perf. But the consequence is that when instantiating a class extracted from a "factory manager" those injections still need to be setup.

[rwjblue]

Here are a few of the steps on the code safari that @workmanw and I just went through:

• store.modelForFactory returns the raw .class property instead of the full result from owner.factoryFor
• InternalModel#getRecord calls ._create on the result of store.modelFactoryFor to instantiate the model instance. Unfortunately, this ._create is completely unaware of injections and is simply calling ._create on the raw unmodified .class.

Most likely we should refactor to return the actual owner.factoryFor('model:foo') result (instead of owner.factoryFor('model:foo').class), however this will pose some issues with the following:

• store._modelForMixin mutates the return value of store.modelFactoryFor to add __mixin and __isMixin properties to the factory.
• store. _modelFor mutates the return value of store.modelFactoryFor (to add the modelName that was used to look up the factory

[rwjblue]

store._modelForMixin mutates the return value of store.modelFactoryFor to add __mixin and __isMixin properties to the factory.

I submitted #4808 to remove this as an issue.

[stefanpenner]

I have some cycles, working on this now.

[workmanw]

@stefanpenner Thanks a lot for jumping on this. I'm happy to help in any way I can.

[stefanpenner]

@workmanw if you have cycles, test out my PR #4810 and let me know if I missed anything.

[rwjblue]

FYI - #4820 backports the fix to release branch (which will likely be released as a 2.11.x bugfix release).