Avoid mutating model factory in _modelForMixin. #4808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the upcoming `factory-for` work it is likely that mutating the result of `modelFactoryFor` will throw an error. This is a minor refactoring to avoid needing to mutate the return value (since we can simply do the work before registering).
rwjblue
force-pushed
the
avoid-mutating-model-factory-1
branch
from
8c54a92 to
9aa6f09
Compare
|
Thanks @rwjblue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the upcoming
factory-forwork it is likely that mutating the result ofmodelFactoryForwill throw an error. This is a minor refactoring to avoid needing to mutate the return value (since we can simply do the work before registering).Addresses one of the issues mentioned in #4807 (comment).