Has many metadata #2878
Closed
Has many metadata #2878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wecc
force-pushed
the
has-many-metadata
branch
3 times, most recently
from
2680704
to
615f58a
Compare
|
This should be good to merge. |
| @@ -0,0 +1,9 @@ | |||
| function cloneNull(source) { | |||
There was a problem hiding this comment.
export default function cloneNull
| @@ -144,6 +145,9 @@ ManyRelationship.prototype.computeChanges = function(records) { | |||
| ManyRelationship.prototype.fetchLink = function() { | |||
| var self = this; | |||
| return this.store.findHasMany(this.record, this.link, this.relationshipMeta).then(function(records) { | |||
| var meta = self.store.metadataFor(self.relationshipMeta.type); | |||
| self.manyArray.set('meta', cloneNull(meta)); | |||
There was a problem hiding this comment.
We have a potential problem here, if you make a request for a record, set some metadata, and then fetch the link, do not set the metadata, this array will end up with wrong metadata. Not sure how to fix this right now
wecc
force-pushed
the
has-many-metadata
branch
2 times, most recently
from
2904134
to
c71260d
Compare
|
|
igorT
added a commit
that referenced
this pull request
Jun 6, 2015
Rebased #2878 and added a test from #2996 Added metadata support behind a feature flag, for hasMany relationships. For now, until we refactor the internals, the store internally pushes hasMany metadata around in the `meta` key next to `links` and `data`. This might lead to overriding meta attribtues with meta relationships, but will be solved by the upcoming change of the internals to JSONAPI format
Merged
|
Superseded by #3221 |
igorT
added a commit
that referenced
this pull request
Jun 9, 2015
Rebased #2878 and added a test from #2996 Added metadata support behind a feature flag, for hasMany relationships. For now, until we refactor the internals, the store internally pushes hasMany metadata around in the `meta` key next to `links` and `data`. This might lead to overriding meta attribtues with meta relationships, but will be solved by the upcoming change of the internals to JSONAPI format
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.