Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata for hasmany #3221

Merged
merged 3 commits into from
Jun 9, 2015
Merged

Metadata for hasmany #3221

merged 3 commits into from
Jun 9, 2015

Conversation

igorT
Copy link
Member

@igorT igorT commented Jun 6, 2015

Happy birthday @wecc
Copied commit message:

Rebased #2878 and added a test from #2996
Added metadata support behind a feature flag, for hasMany relationships.
For now, until we refactor the internals, the store internally pushes hasMany
metadata around in the meta key next to links and data.
This might lead to overriding meta attribtues with meta relationships,
but will be solved by the upcoming change of the internals to JSONAPI format

wecc and others added 3 commits June 6, 2015 05:46
Rebased #2878 and added a test from #2996
Added metadata support behind a feature flag, for hasMany relationships.
For now, until we refactor the internals, the store internally pushes hasMany
metadata around in the `meta` key next to `links` and `data`.
This might lead to overriding meta attribtues with meta relationships,
but will be solved by the upcoming change of the internals to JSONAPI format
@wecc
Copy link
Contributor

wecc commented Jun 6, 2015

👍

igorT added a commit that referenced this pull request Jun 9, 2015
@igorT igorT merged commit 2c2b0d4 into master Jun 9, 2015
@igorT igorT deleted the metadata-for-hasmany branch June 9, 2015 04:56
@wecc wecc mentioned this pull request Jun 10, 2015
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants