[CHORE tests] modernize unit/model/lifecycle-callbacks-test #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
runspired
force-pushed
the
modernize-lifecycle-tests
branch
from
65634f7 to
4801ee4
Compare
igorT
reviewed
Oct 31, 2018
| assert.strictEqual( | ||
| lifecycleEventMethodCalls, | ||
| 1, | ||
| 'We do not trigger didDelete when we first call record.deleteRecord' |
igorT
reviewed
Oct 31, 2018
| return person.save().catch(reason => { | ||
| assert.ok(reason.isAdapterError, 'reason should have been an adapter error'); | ||
| await person.save().catch(reason => { | ||
| assert.strictEqual(lifecycleEventMethodCalls, 1, 'We trigger becameInvalid when we reject'); |
There was a problem hiding this comment.
Just curious, what are the reasons for preferring strictEqual over equal in some cases?
There was a problem hiding this comment.
I use strictEqual when we do expect strict referential equality. The advantage is two-fold: (1) it avoids a set of bugs that happen when qunit attempts to do deep recursive "looks like the same thing" comparisons when strict equality is not matched (on records this is a mega perf hit in addition to being risky), and (2) it is an improvement over the alternative pattern of assert.ok(foo === bar, '') wherein if the assertion fails there is no additional information printed about what the incorrect value is without stepping into the test.
igorT
approved these changes
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ported from #5708