[BUGFIX inspector] Fix columns names in debug-adapter

[thorsteinsson]

Fixed formatting of column desc to support many words. It used to replace only the first underscore with space and leave the rest.

[runspired]

@thorsteinsson the tests file is tests/integration/debug-adapter-test.js, if you have a moment, if you could modernize it while working on it that would be awesome.

Example modernization PRs:

• [CHORE tests] modernize integration/store/serializer-for-test #5712
• [CHORE tests] modernize integration/peek-all-test #5713
• [CHORE tests] modernize integration/record-array-test #5714
• [CHORE tests] modernize integration/inverse-test #5715
• [CHORE tests] modernize integration/client-id-generation-test #5716
• [CHORE tests] modernize unit/model/lifecycle-callbacks-test #5717

[runspired]

@thorsteinsson so after reviewing this I'm fairly sure that whatever issue is being seen in Ember inspector is not related to ember-data. Ember Data does not and never has allowed users to use a property other than id as the primaryKey field on Model. The primaryKey modification shown in the associated PR is a pre-normalization or post-serialization property name unrelated to the store's internal format or the interface available on Model.

When we interface with the data-adapter we are always dealing with normalized data, and thus will only ever be using id. Either a different data-adapter for a different data-layer is interfacing with the inspector in an incorrect way or there's some other bug involved.

[thorsteinsson]

@runspired Makes sense, I wanted to use the same column name as defined in the model to provide better info in the inspector. I can change that back to id and only fix how the data is returned based on primaryKey.

I've tested the changes with the Inspector and it works. I'll work on modernizing the tests.

Since the DebugAdapter is only used to get debug information (I guess), should be only included in dev builds or be in a separate repo? There's a comment at https://github.com/emberjs/data/blob/master/addon/-private/index.js#L45

[thorsteinsson]

I changed it back to use id and made sure we return a value for when primaryKey has been set (id is not set).