-
-
Notifications
You must be signed in to change notification settings - Fork 257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose warning management primitives #1078
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanpenner
force-pushed
the
warnings
branch
3 times, most recently
from
August 3, 2021 18:19
b21b8ec
to
a6096f0
Compare
rwjblue
changed the title
emberjs/warning-primitives
Expose warning management primitives
Aug 3, 2021
rwjblue
requested changes
Aug 3, 2021
stefanpenner
force-pushed
the
warnings
branch
4 times, most recently
from
August 3, 2021 21:14
7312bfd
to
09b5015
Compare
This was referenced Aug 3, 2021
rwjblue
approved these changes
Aug 3, 2021
rwjblue
approved these changes
Aug 4, 2021
This is failing due to the following:
Investigating now. |
Expose deprecation primitives * `?disableWarnings` queryParam * `?debugWarnings` queryParam * `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;` This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default. --- Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default. I was lead down this path getting embroider working properly on `ember@canary` --- enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
the failure is unrelated to this issue, and I'm investigating it independently... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expose warning primitives:
?disableWarnings
queryParam?debugWarnings
queryParamimport { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;
This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default.
Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their
@ember/test-helpers
+ember-qunit
they will now get the original functionality, + async + bugfixes by default.I was lead down this path getting embroider working properly on
ember@canary
enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)