Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose warning management primitives #1078

Merged
merged 1 commit into from
Aug 4, 2021
Merged

Expose warning management primitives #1078

merged 1 commit into from
Aug 4, 2021

Conversation

stefanpenner
Copy link
Member

@stefanpenner stefanpenner commented Aug 3, 2021

Expose warning primitives:

  • ?disableWarnings queryParam
  • ?debugWarnings queryParam
  • import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;

This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default.


Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their @ember/test-helpers + ember-qunit they will now get the original functionality, + async + bugfixes by default.

I was lead down this path getting embroider working properly on ember@canary


enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)

@stefanpenner stefanpenner marked this pull request as draft August 3, 2021 18:13
@stefanpenner stefanpenner force-pushed the warnings branch 3 times, most recently from b21b8ec to a6096f0 Compare August 3, 2021 18:19
@rwjblue rwjblue changed the title emberjs/warning-primitives Expose warning management primitives Aug 3, 2021
@stefanpenner stefanpenner marked this pull request as ready for review August 3, 2021 20:06
@stefanpenner
Copy link
Member Author

This is failing due to the following:

not ok 473 Chrome 92.0 - [undefined ms] - Global error: Uncaught TypeError: Cannot read property 'length' of undefined at webpack://__ember_auto_import__/./node_modules/qunit/qunit/qunit.js?, line 2345
 After execution of test: DOM helper: waitUntil: does not continue to wait if callback throws
    ---
        browser log: |
            {"type":"error","text":"Uncaught TypeError: Cannot read property 'length' of undefined at webpack://__ember_auto_import__/./node_modules/qunit/qunit/qunit.js?, line 2345\n","testContext":{"id":472,"name":"DOM helper: waitUntil: does not continue to wait if callback throws","items":[],"state":"complete"}}

Investigating now.

Expose deprecation primitives

* `?disableWarnings` queryParam
* `?debugWarnings` queryParam
* `import { getWarnings, getWarningsDuringCallback } from ‘@ember/test-helpers’;`

This is a second step in allowing us to deprecate https://github.com/workmanw/ember-qunit-assert-helpers in-favor of these helpers simply being provided by default.

---

Context: This is motivated by 4.0 changes that are incompatible with the original add-on, and the time trade-off of resurrecting that add-on vs adopting its great ideas into mainline. Although users will need to upgrade their `@ember/test-helpers` + `ember-qunit` they will now get the original functionality, + async + bugfixes by default.

 I was lead down this path getting embroider working properly on `ember@canary`

---

 enables resolving emberjs/ember-string#259 amongst other related issues (basically anyone consuming ember-qunit-assert-helpers)
@stefanpenner
Copy link
Member Author

the failure is unrelated to this issue, and I'm investigating it independently...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants