Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated wait tests. #273

Merged
merged 1 commit into from
Dec 15, 2017

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Dec 15, 2017

These tests are the exact same tests as exist in tests/integration/settled-test.js, but with the import wait from 'ember-test-helpers/wait' instead of import { settled } from '@ember/test-helpers'. The two utility functions are exactly the same (wait is a reexport of settled), so there is no reason to test both versions like this.

This fixes an annoying flakey test that keeps showing up in CI. The corresponding test was already fixed in settled-test.js to handle async properly, but the broken (and flakey) version still existed here causing sporadic failures. Instead of fixing the issue and forcing all future settled-test.js changes to have to remember to also update this duplicated file, I chose to delete it...

These tests are the exact same tests as exist in
`tests/integration/settled-test.js`, but with the `import wait from
'ember-test-helpers/wait'` instead of `import { settled } from
'@ember/test-helpers'`.  The two utility functions are _exactly_ the
same (`wait` is a reexport of `settled`), so there is no reason to test
both versions like this.

This fixes an annoying flakey test that keeps showing up in CI. The
corresponding test was already fixed in `settled-test.js` to handle
async properly, but the broken (and flakey) version still existed here
causing sporadic failures. Instead of fixing the issue and forcing all
future `settled-test.js` changes to have to remember to _also_ update
this duplicated file, I chose to delete it...
@rwjblue rwjblue merged commit bbe8ddc into emberjs:master Dec 15, 2017
@rwjblue rwjblue deleted the remove-duplicated-wait-tests branch December 15, 2017 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant