Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests are the exact same tests as exist in
tests/integration/settled-test.js
, but with theimport wait from 'ember-test-helpers/wait'
instead ofimport { settled } from '@ember/test-helpers'
. The two utility functions are exactly the same (wait
is a reexport ofsettled
), so there is no reason to test both versions like this.This fixes an annoying flakey test that keeps showing up in CI. The corresponding test was already fixed in
settled-test.js
to handle async properly, but the broken (and flakey) version still existed here causing sporadic failures. Instead of fixing the issue and forcing all futuresettled-test.js
changes to have to remember to also update this duplicated file, I chose to delete it...