Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated wait tests. #273

Merged
merged 1 commit into from
Dec 15, 2017

Commits on Dec 15, 2017

  1. Remove duplicated wait tests.

    These tests are the exact same tests as exist in
    `tests/integration/settled-test.js`, but with the `import wait from
    'ember-test-helpers/wait'` instead of `import { settled } from
    '@ember/test-helpers'`.  The two utility functions are _exactly_ the
    same (`wait` is a reexport of `settled`), so there is no reason to test
    both versions like this.
    
    This fixes an annoying flakey test that keeps showing up in CI. The
    corresponding test was already fixed in `settled-test.js` to handle
    async properly, but the broken (and flakey) version still existed here
    causing sporadic failures. Instead of fixing the issue and forcing all
    future `settled-test.js` changes to have to remember to _also_ update
    this duplicated file, I chose to delete it...
    rwjblue committed Dec 15, 2017
    Configuration menu
    Copy the full SHA
    f762b7c View commit details
    Browse the repository at this point in the history