-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Root template ignored by router in 11-beta.5 #10658
Comments
Also going to put this here because I believe it's related #10602 |
I have a fix for this on in #10683 |
ef4
added a commit
to ef4/ember.js
that referenced
this issue
Mar 20, 2015
Closes emberjs#10478 by changing the way we account for routes that don't do a default `render()`. Fixes issue in comments of emberjs#10606 to make us tolerant of multiple renders on top of each other. Close emberjs#10658 by respecting a non-default template rendered into a main outlet as our own template. Close emberjs#10606 by running disconnectOutlet against all active routes, not just the current one. (*shudder*)
@ef4 That solved it, thanks Edward! ⛵ |
ef4
added a commit
that referenced
this issue
Mar 26, 2015
Closes #10478 by changing the way we account for routes that don't do a default `render()`. Fixes issue in comments of #10606 to make us tolerant of multiple renders on top of each other. Close #10658 by respecting a non-default template rendered into a main outlet as our own template. Close #10606 by running disconnectOutlet against all active routes, not just the current one. (*shudder*) (cherry picked from commit a994491)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
With 1.11 beta 5 the 'root' template/view is ignored in my route hierarchy. Images and code below (let me know if I should clarify further).
Possibly after this change (haven't bisected though): ba1d1a6
cc @ef4 Edward, any thoughts on what may cause this?
(I'm happy to provide more details, jump on Screenhero or similar)
Routes (same in both versions)
With 1.8
With 1.11-beta5
The text was updated successfully, but these errors were encountered: