[BUGFIX beta] Fix outlet regression #10683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes emberjs#10478 by changing the way we account for routes that don't do a default `render()`. Fixes issue in comments of emberjs#10606 to make us tolerant of multiple renders on top of each other. Close emberjs#10658 by respecting a non-default template rendered into a main outlet as our own template. Close emberjs#10606 by running disconnectOutlet against all active routes, not just the current one. (*shudder*)
rwjblue
added a commit
that referenced
this pull request
Mar 20, 2015
[BUGFIX beta] Fix outlet regression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10478 by changing the way we account for routes that don't do a default
render().Fixes an issue reported in the comments of #10606 to make us tolerant of multiple renders on top of each other.
Closes #10606 by applying disconnectOutlet to all active routes.
Closes #10658 by respecting a non-default template rendered into the main outlet as our own template.