Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added failing test to tackle down misbehaving nested named outlets #10660

Closed
wants to merge 1 commit into from

Conversation

fpauser
Copy link
Contributor

@fpauser fpauser commented Mar 18, 2015

No description provided.

@fpauser
Copy link
Contributor Author

fpauser commented Mar 18, 2015

Related to #10652

@ef4
Copy link
Contributor

ef4 commented Mar 20, 2015

Thanks, picking apart this failing test helped me uncover a regression (#10683).

However, this test case overall is doing some ambiguous stuff that -- if it ever worked -- only worked out of sheer luck.

The biggest problem is that it tries to render the same template multiple times into different places at the same time. For example, when handling the url /section/subsection/sub1/1/edit the template section/subsection/sub1 gets render by SectionSubsectionRoute and by SectionSubsectionSub1Route simultaneously.

@ef4 ef4 closed this Mar 20, 2015
@fpauser
Copy link
Contributor Author

fpauser commented Mar 20, 2015

@ef4 So my example cannot be done with the current router/outlet logic, or do I miss something here?

@ef4
Copy link
Contributor

ef4 commented Mar 20, 2015

Your example can certainly be made to work. But it will need to be changed to not try to render the same template into multiple places simultaneously.

Here's an edit to your original jsbin that's changed to avoid double rendering the same templates, and to force the children to share the same controller. http://emberjs.jsbin.com/fuzavecidu/3/edit

(I'm not recommended the above as a good way to organize this app, I'm just showing the minimal changes that would make your example work.)

@fpauser
Copy link
Contributor Author

fpauser commented Mar 20, 2015

Thanks for sharing the fix to my jsbin. Now I get what goes wrong - although I do not understand why it is mandatory to provide a controller doing a 'customized' render...

At least my bad example helped/inspired you somehow ;)

@fpauser fpauser deleted the failing_nested_named_outlets branch March 20, 2015 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants