Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression: Nested {{render}} helpers result in Uncaught TypeError #10827

Closed
awaer opened this issue Apr 4, 2015 · 14 comments
Closed

Regression: Nested {{render}} helpers result in Uncaught TypeError #10827

awaer opened this issue Apr 4, 2015 · 14 comments
Milestone

Comments

@awaer
Copy link

awaer commented Apr 4, 2015

Using nested {{render}} helpers results in Uncaught TypeError: undefined is not a function. It seems this began with the changes made in #10602 (d8a16a4) for 1.11.0.

This JSBin reproduces a simple example: http://emberjs.jsbin.com/moxugi/1/edit?html,js,console,output

(carried over from #10760)

@JackCA
Copy link

JackCA commented Apr 6, 2015

I believe I just hit this as well

@michaeldeitcher
Copy link

I'm looking forward to a fix for this regression. Thanks

@alexdiliberto
Copy link
Contributor

I can confirm this regression as well. After banging my head for a little bit I realized this was the problem with the nested {{render}} helpers

+@ef4

@rwjblue rwjblue added this to the 1.11.2 milestone Apr 6, 2015
@ef4
Copy link
Contributor

ef4 commented Apr 6, 2015

I see the problem. The render helper impersonates an outlet, but not well enough for when it is its own recursive child. It needs to get a _parentOutlet() method too.

I don't know if I'll be able to get to this right away, if somebody else wants to take a stab at it it shouldn't be too difficult. Update the impersonateAnOutlet function to set view._parentOutlet to a function that works the same way OutletView's function of the same name works.

@dcheng168
Copy link

+1, having same problems

@phlppn
Copy link

phlppn commented Apr 7, 2015

+1

@awaer
Copy link
Author

awaer commented Apr 7, 2015

Here's the same example from above using the PR build: http://emberjs.jsbin.com/jolisu/1/edit?html,js,console,output

@ryanjm
Copy link

ryanjm commented Apr 9, 2015

Just hit the same thing.

@awaer
Copy link
Author

awaer commented Apr 9, 2015

I notice this issue was left open after the PR was merged. @rwjblue Is there anything left pending that I can help with?

@rwjblue
Copy link
Member

rwjblue commented Apr 9, 2015

@awaer - I need to cherry-pick the fix up from stable branch, so I left the issue open. Just pulled in those commits, so closing now (thanks for the reminder!)...

@rwjblue rwjblue closed this as completed Apr 9, 2015
@davidpett
Copy link
Contributor

@rwjblue any info on a 1.11.2 release for this regression? is there anything I can help with?

nag5000 added a commit to Flexberry/ember-flexberry that referenced this issue Apr 14, 2015
@ChrisHonniball
Copy link

@rwjblue I'm getting bit by this bug in 1.11.2. Was there a solution somewhere? If so, I'm unable to locate it. Thanks!

@rwjblue
Copy link
Member

rwjblue commented Apr 16, 2015

@ChrisHonniball - Update to 1.11.3.

@ChrisHonniball
Copy link

Update to 1.11.3.

Oh thank you! I read this post SECURITY AND BUGFIX RELEASES - EMBER 1.10.1, 1.11.2, 1.11.3 and stopped at 1.11.2... Sorry.

Now on to deprecations! ✊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests