-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX release] Fix nested render helpers #10843
Conversation
Looks good to me. @ef4 - Can you 👍 / 👎? |
Looks good to me. |
@awaer Can you add a test similar to https://github.com/awaer/ember.js/blob/53832b348c76147b345f44ceea2e3c8e138a0a06/packages/ember/tests/routing/basic_test.js#L3744-L3769 that tests an outlet inside of nested {{render}} calls? |
"This branch has failed checks, but can be merged." I'm unfamiliar with the Travis CI feedback -- is this referring to something I need to resolve on this PR? |
Phantom crashed. I just restarted that Travis build. |
This commit is targeting |
This is passing, so I'll just cherry-pick the other way (from stable to beta and master). |
[BUGFIX release] Fix nested render helpers
Sorry for the branch mixup. Thanks, @rwjblue |
@awaer - No worries! |
This is still an issue in 1.11.1 http://jsbin.com/yiwama/1/edit?html,js,console,output Any chance this can be released or are there still issues with it? |
@bfcoder This is fixed with today's 1.11.3 release http://jsbin.com/doheto/1/edit |
@alexdiliberto I'm not seeing any release past 1.11.1 https://rubygems.org/gems/ember-source Nor in ember-cli is it past 1.11.1 |
Ok, I'll just have to be patient for it to be released to the gem. :] Thanks! |
@rwjblue Any chance that 1.11.3 could be released to the ember-source gem? Or are there still issues that would prevent the release? Thanks! |
Fixes #10827
This simply applies the change described by @ef4 in this comment: #10827 (comment)