Deprecate and remove function argument in Ember.assert/deprecate/etc

[mmun]

The following should throw a deprecation:

Ember.deprecate(msg, function() { return true; })

The message should be something like "Functional arguments are ambiguous with constructors. Please use !!Constructor for constructors, or an IIFE to compute the deprecation value. In a future version of Ember functions will be treated as truthy values instead of being executed."

Needs to be deprecated in stable (1.13), removed in beta (2.0).

[rodrigo-morais]

Hello @mmun and @rwjblue,

I'd love become me a new contributor, and I think this issue is a good one to start.
I can't find where I should work to solve this issue.

Would you mind giving me some tips?

Thanks.

[KevinTCoughlin]

I've attempted to partially resolve this issue in #11933. Would appreciate any advice for fully satisfying the issue and any problems with my PR. Thank you.

[e00dan]

@rwjblue, @stefanpenner is it still possible to create pr with deprecation or you will just remove this functionality? @mmun has written that it should be remove in beta 2.0.

[mmun]

It's far too late for this, but we can do it now in preparation for Ember 3.0.

[kylemellander]

In researching this, it looks like @kuzirashi has done a lot of great work moving this along in [https://github.com//pull/12370](PR 12370). I would love to help move this forward if it needs more work, or have it closed if Kuzirashi's work finished it.

[rwjblue]

@kylemellander - Thanks for doing the research on this, I think this is closed!