Deprecate Ember.deprecate test function argument

[KevinTCoughlin]

This PR deprecates:

• Ember.deprecate when test is supplied as a function

Partially resolving #11898. As mentioned, it should be kept around until 2.0.0.

Would like fully resolve #11898, however unsure how to handle the assert, etc. cases. Could use some guidance as this is my first contribution. Thanks!

/cc @mmun @rwjblue

[rwjblue]

This looks good, thank you for working on it!

Moving the deprecation to around here would make this PR handled both Ember.deprecate and Ember.warn (since both use the same logic). Alternatively, you could take the same tactic that you did in ember-debug/deprecate for ember-debug/warn.

As for Ember.assert, you can take a look here for where to deprecate.

[KevinTCoughlin]

Moving the deprecation to around here would make this PR handled both Ember.deprecate and Ember.warn (since both use the same logic).

@rwjblue: I'd like to do that & may be missing an obvious workaround, but deprecate and warn will then be recursive unless I add a way to short-circuit invoke.