[BUGFIX canary] Deprecate passing function as test argument to deprecate/warn/assert

[e00dan]

This PR attempts to deprecate using function as test argument in: Ember.deprecate, Ember.warn and Ember.assert. It's first part of closing issue #11898. Tests for ember-debug pass, but I still have to fix other tests and code, which trigger deprecation with function as test argument. Seems like this behavior is used in many places in application lifecycle. It's my first attempt to commit actual code to Ember.js so I appreciate any help.

@mmun, @rwjblue

[e00dan]

All tests pass. (sauce test suite pass sometimes, sometimes it needs to re-run... it is really misleading)

Also, it seems to me that packages/ember-htmlbars/lib/node-managers/view-node-manager.js isn't tested properly, so I've added basic test coverage to at least check if test condition in assert is correct.

@mmun, @rwjblue

[e00dan]

@rwjblue should I rebase or you aren't interested in this pr?

[stefanpenner]

i would be in favor, but will defer to @rwjblue

[e00dan]

@rwjblue any feedback on this?

[mmun]

@kuzirashi Sorry for no feedback. I'm definitely 👍 on this.

[e00dan]

Thanks @mmun! I'm waiting for signal from @rwjblue and I'll eventually rebase and squash.

[rwjblue]

Lets just remove the reference to using a function all together.

[rwjblue]

@kuzirashi - This looks very good. I have left a few pretty minor comments. When you have time can you fixup the comments, squash, and rebase?

[e00dan]

I'll find the time. I'll mention you when it's all ready. Thanks for review. ;)

[rwjblue]

I agree with @mmun though, this deprecation should probably not be [BUGFIX release]. In order to allow addons to deal with the new deprecation in an orderly way, I'd like to land this on master before branching into 2.2 beta (which should be in the next few days). That gives folks the full beta cycle (~6weeks) to get things updated in addons so this doesn't impact end user apps much.

tldr; can you update to use [BUGFIX canary] instead?

[e00dan]

Sure it'll be changed to [BUGFIX canary].

[e00dan]

Rebased, squashed, tests pass. Except tests on sauce which randomly pass or fail from my experience. @rwjblue

[rwjblue]

Awesome, thanks for your hard work on this @kuzirashi!

[rwjblue]

@kuzirashi - Would you mind submitting a PR to https://github.com/emberjs/website/blob/master/source/deprecations/v2.x.html.md adding a section on this for 2.2?

[e00dan]

Sure :)

[e00dan]

PR in website repo created. @rwjblue