Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArrayProxy mutation no longer notifying dependent keys between 2.0.0-beta.5 - 2.0.0 #12083

Closed
gpoitch opened this issue Aug 13, 2015 · 4 comments
Closed

ArrayProxy mutation no longer notifying dependent keys between 2.0.0-beta.5 - 2.0.0 #12083

gpoitch opened this issue Aug 13, 2015 · 4 comments

Comments

@gpoitch
Copy link
Contributor

gpoitch commented Aug 13, 2015

http://emberjs.jsbin.com/hanexihomo/1/edit?js,output // Ember 2.0.0 final (broken)
http://emberjs.jsbin.com/camajexebe/1/edit?js,output // Ember 2.0.0-beta.5 (works)
@rwjblue
Copy link
Member

rwjblue commented Aug 13, 2015

Based on the diff between versions, #12036 seems most likely to have caused an issue.

@krisselden / @ef4 / @stefanpenner - Would one of y'all be able to take a look?

@stefanpenner
Copy link
Member

ill look now.

stefanpenner added a commit to stefanpenner/ember.js that referenced this issue Aug 13, 2015
@stefanpenner
Failing tests for emberjs#12083
dadcaaf
@stefanpenner
Copy link
Member

I've created a relatively thorough failing test case: https://github.com/emberjs/ember.js/pull/12087/files

@stefanpenner
Copy link
Member

it appears the issue originated with e25b57c – it is not yet clear to me that the commit in question actually caused the issue, or merely exposed an underlying issue. Further investigation is needed.

stefanpenner added a commit that referenced this issue Aug 14, 2015
@stefanpenner @krisselden
Failing tests for #12083
1e0b50d
krisselden added a commit that referenced this issue Aug 14, 2015
@krisselden
[BUGFIX release] Fix #12083
b610b2f
rwjblue added a commit that referenced this issue Aug 14, 2015
@rwjblue
Merge pull request #12093 from emberjs/fix-lazy-get-bug
57295d5 
[BUGFIX release] Fix #12083
stefanpenner added a commit that referenced this issue Aug 14, 2015
@stefanpenner
Failing tests for #12083
dd93ba5
krisselden added a commit that referenced this issue Aug 14, 2015
@krisselden @stefanpenner
[BUGFIX release] Fix #12083
c0975b1
stefanpenner added a commit to rwjblue/ember.js that referenced this issue Aug 14, 2015
@stefanpenner @rwjblue
Failing tests for emberjs#12083
d5564c2 
(cherry picked from commit 1e0b50d)
krisselden added a commit to rwjblue/ember.js that referenced this issue Aug 14, 2015
@krisselden @rwjblue
[BUGFIX release] Fix emberjs#12083
f48ffea 
(cherry picked from commit b610b2f)
@rwjblue rwjblue mentioned this issue Aug 14, 2015
Merged
@fivetanley fivetanley mentioned this issue Aug 26, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stefanpenner @rwjblue @gpoitch