Failing tests for ArrayProxy#length cacheing issue #12218
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| equal(proxy.get('length'), 3, 'precond - length is 3'); | ||
|
|
||
| // Trigger computed property that depends on length |
bmac
force-pushed
the
failing-array-proxy-length
branch
from
e0c8a6a to
941f245
Compare
|
git bisect suggests the issue was introduce in this commit b799c3b |
|
@bmac - Awesome, thank you for bisecting! |
bmac
added a commit
to bmac/data
that referenced
this pull request
Aug 27, 2015
This is a workaround for emberjs/ember.js#12218
bmac
added a commit
to bmac/data
that referenced
this pull request
Aug 27, 2015
This is a workaround for emberjs/ember.js#12218
This was referenced Sep 2, 2015
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Ember Data tests are currently failing (issue started on August 24th) with the canary build of ember.
I've tracked in down to an issue with the
lengthproperty of an ArrayProxy. In Ember beta (2.1) and release (2.0) channelslengthupdates when setting a newcontentarray on the ArrayProxy. However, in the canary channel thelengthproperty is not updated until there is some other mutation performed on the ArrayProxy.When debugging this issue I also noticed it only seems to happen when there is an computed property that depends on the
lengthproperty. If there is no depended computed propertylengthwill return the correct value.