Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Triple stash with undefined content at top of template causes view to repeat #14924

Closed
czosel opened this issue Feb 10, 2017 · 3 comments
Closed

Triple stash with undefined content at top of template causes view to repeat #14924

czosel opened this issue Feb 10, 2017 · 3 comments
Labels
Bug Glimmer2 Has Reproduction

Comments

@czosel
Copy link

czosel commented Feb 10, 2017

I just stumbled over this bug that only seems to occur if your template starts with

{{{somethingUndefined}}}

When you switch back and forth between views, the template is rendered multiple times. This only seems to affect Glimmer 2.

For a working reproduction please see this ember-twiddle.
@rwjblue
Copy link
Member

rwjblue commented Feb 16, 2017

This is definitely pretty weird behavior, thank you for reporting (and for the reproduction)!

@Panman82 Panman82 mentioned this issue Mar 6, 2017
Closed
@locks locks mentioned this issue Jul 2, 2017
Closed
This was referenced Mar 2, 2018
Closed
Closed
@mapeveri
Copy link

I would like to take this issue, I am new and I would like to know where to start if possible. Thanks!

@Panman82 Panman82 mentioned this issue May 29, 2018
Closed
@chancancode chancancode mentioned this issue Sep 24, 2018
Merged
chancancode added a commit to glimmerjs/glimmer-vm that referenced this issue Sep 24, 2018
@chancancode @mongoose700
Fix emberjs/ember.js#14978
08c56fa 
Likely related:

emberjs/ember.js#14924
emberjs/ember.js#16172
emberjs/ember.js#16314

Closes #791

Co-authored-by: Michael Peirce <msp700@gmail.com>
@chancancode chancancode mentioned this issue Sep 25, 2018
Merged
4 tasks
chancancode added a commit that referenced this issue Sep 25, 2018
@chancancode
Add failing test for #14924 and #16172
8a46c18
chancancode added a commit to glimmerjs/glimmer-vm that referenced this issue Sep 25, 2018
@chancancode @mongoose700
Fix emberjs/ember.js#14978
0cdc903 
Likely related:

emberjs/ember.js#14924
emberjs/ember.js#16172
emberjs/ember.js#16314

Closes #791

Co-authored-by: Michael Peirce <msp700@gmail.com>
chancancode added a commit that referenced this issue Sep 25, 2018
@chancancode
Bump @glimmer/*
be1f045 
Fixes #14978, #14924, #16172, #16314
chancancode added a commit that referenced this issue Sep 25, 2018
@chancancode
Add failing test for #14924 and #16172
830d766
chancancode added a commit that referenced this issue Sep 25, 2018
@chancancode
Bump @glimmer/*
283dcd1 
Fixes #14978, #14924, #16172, #16314
chancancode added a commit that referenced this issue Sep 25, 2018
@chancancode
Add failing test for #14924 and #16172
8f67aec 
(cherry picked from commit 830d766)
chancancode added a commit that referenced this issue Sep 25, 2018
@chancancode
Bump @glimmer/*
e61ecf8 
Fixes #14978, #14924, #16172, #16314

(cherry picked from commit 283dcd1)
@chancancode chancancode mentioned this issue Sep 25, 2018
Merged
4 tasks
chancancode added a commit that referenced this issue Sep 25, 2018
@chancancode
Add failing test for #14924 and #16172
b5ab036 
(cherry picked from commit 830d766)
chancancode added a commit that referenced this issue Sep 25, 2018
@chancancode
Bump @glimmer/*
83f5f51 
Fixes #14978, #14924, #16172, #16314

(cherry picked from commit 283dcd1)
@chancancode chancancode mentioned this issue Sep 25, 2018
Merged
4 tasks
@chancancode
Copy link
Member

Sorry it took so long, this is fixed in 3.4.3 (#17003)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Glimmer2 Has Reproduction
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@rwjblue @locks @chancancode @mapeveri @czosel