Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Triple braces sometimes render wrong #14978

Closed
luxzeitlos opened this issue Mar 2, 2017 · 7 comments · Fixed by ember-template-lint/ember-template-lint#530
Closed

Triple braces sometimes render wrong #14978

luxzeitlos opened this issue Mar 2, 2017 · 7 comments · Fixed by ember-template-lint/ember-template-lint#530

Comments

@luxzeitlos
Copy link
Contributor

luxzeitlos commented Mar 2, 2017

The following template:

<h1>head</h1>
{{{model}}}
<div>foot</div>

sometimes results in rendering the content of model after the <div>foot</div>.

Reproduction: https://ember-twiddle.com/2cadbc4061c5444402d3462afd892ce7?openFiles=templates.application.hbs%2C&route=%2Fmy-route%2F2

For reproduction first click "1", then click "2". It works if you directly click on the "2".

@Serabe
Copy link
Member

Serabe commented Mar 2, 2017

Thank you for your report!

@Panman82
Copy link
Contributor

Panman82 commented Mar 6, 2017

Is this related/duplicate of #14924 ? Does this also apply to a Component? Or just Controller/View related?

@luxzeitlos
Copy link
Contributor Author

Its not a duplicate, but it might be related. #14924 is double-rendering handlebars content, this here is rendering content at the wrong place. I was not yet able to reproduce for components, however I'm not sure what exactly is triggering it.

@zackthehuman
Copy link
Contributor

Could this be due to how we track bounds? If we render a bounds for "" do we somehow get off track? /cc @krisselden @chancancode

@pixelhandler
Copy link
Contributor

pixelhandler commented Sep 14, 2018

@Panman8201 @Serabe @locks @luxferresum @pixelhandler @zackthehuman is this still an issue, perhaps we should close or create a new reproduction of this, what do you think?

Well, when I update the twiddle to use v3.4.1 I see the same behavior that was described, https://ember-twiddle.com/ad4caff1df05cb505323cd7914ea842c?openFiles=templates.my-route.hbs%2C&route=%2Fmy-route%2F2

chancancode added a commit to glimmerjs/glimmer-vm that referenced this issue Sep 23, 2018
chancancode added a commit to glimmerjs/glimmer-vm that referenced this issue Sep 23, 2018
chancancode added a commit to glimmerjs/glimmer-vm that referenced this issue Sep 23, 2018
wycats added a commit to glimmerjs/glimmer-vm that referenced this issue Sep 25, 2018
@chancancode chancancode reopened this Sep 25, 2018
@chancancode
Copy link
Member

Leaving this open until the fix lands in ember and backported into LTS

chancancode added a commit that referenced this issue Sep 25, 2018
chancancode added a commit to glimmerjs/glimmer-vm that referenced this issue Sep 25, 2018
Likely related:

emberjs/ember.js#14924
emberjs/ember.js#16172
emberjs/ember.js#16314

Closes #791

Co-authored-by: Michael Peirce <msp700@gmail.com>
chancancode added a commit that referenced this issue Sep 25, 2018
chancancode added a commit that referenced this issue Sep 25, 2018
chancancode added a commit that referenced this issue Sep 25, 2018
(cherry picked from commit 793d123)
chancancode added a commit that referenced this issue Sep 25, 2018
Fixes #14978, #14924, #16172, #16314

(cherry picked from commit 283dcd1)
chancancode added a commit that referenced this issue Sep 25, 2018
(cherry picked from commit 793d123)
@chancancode
Copy link
Member

Sorry it took so long, this is fixed in 3.4.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants