[FEATURE ember-router-willtransition] #10274
Conversation
Invoke willTransition function and event on Router, just like Route. Addresses emberjs#10235
|
👍 Not sure if this should be feature flagged or not. |
|
This adds new API so it will need a feature flag. |
asakusuma
changed the title
wagenet
added
Needs Label Review
Feature
Needs Submitter Response
and removed
Needs Label Review
labels
|
@wagenet why was the "Needs Submitter Response" tag added here? Is there something else I need to provide? |
|
He likely didn't see that you updated the PR as requested. |
Ember.Test.unregisterWaiter is supposed to unregister only the waiter that matches the arguments you pass it. Due to a bug it actually unregisters all waiters with the same context.
In prior versions of Ember you could render attributes via:
```
<div {{someHelper}}></div>
```
This brings that back.
* Return value of helper function is not used when using a block. * Calling `options.fn()` in a compat helper automatically appends content.
* tildeio/route-recognizer#41 adds es6 build to npm package, released as 0.1.5 * emberjs/emberjs-build#63 updates emberjs-build to use npm vendored RR, released as 0.0.22
Also removes a bunch of argument slices in the macros.
A bug in Esperanto makes this not function properly. The bug has been fixed, but I believe that this still results in a more readable implementation.
Seems like `eachComputedProperty` and `metaForProperty` are actually static members of Ember.CoreObject. I was confused when `console.log()` of `instanceOfEmObject.eachComputedProperty` returned `undefined`. However I could use it with `Foo.eachComputedProperty()` where `Foo = Em.Object.extend();`. [Demo here](http://emberjs.jsbin.com/powelibeve/4/edit). I hope it will save time and frustration of other developers.
Conflicts: bower.json
[BUGFIX release] view keyword should not chain directly off parent's view keyword
|
Can anyone shed light on why it's failing now? Was passing before I merged bower.json. Here is the job that is failing: https://travis-ci.org/emberjs/ember.js/jobs/48380622 I don't see any errors besides the |
|
@machty mind taking a look? |
|
@asakusuma regardless of these issues you'll need to rebase your changes on top of master and squash your (presently) 3 commits into one; once you do that, you might find that the issues you're running into magically disappear, so give that a shot first. |
…elper-fix [FEATURE] ember-testing-checkbox-helpers
Add support for willTransition in Ember.Router Addresses emberjs#10235
Conflicts: FEATURES.md
Invoke willTransition function and event on Router, just like Route.
Addresses #10235