Make LinkView FastBoot™-compatible #10316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 30, 2015 15:29
This commit provides a mechanism for the renderer to disable invoking the `willInsertElement` and `didInsertElement`. This private API is used by FastBoot to ensure that code that relies on DOM does not get invoked in the Node.js context. It is possible that a better future solution would be to have the code that is responsible for actually inserting the element into DOM also be responsible for invoking the hooks (i.e., appendTo and replaceIn). `didInsertElement` should probably not be invoked in any `createElement` phase, but we leave that work for future commits.
tomdale
changed the title
tomdale
added a commit
that referenced
this pull request
Jan 31, 2015
Make LinkView FastBoot™-compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the DOM dependency of LinkView. It also includes tests for Node.js that exercise creating an app instance and rendering a template with a
{{link-to}}.This branch is ready to go once HTMLbars has been updated with the necessary DOMHelper hook (see tildeio/htmlbars#273).