This repository was archived by the owner on Apr 4, 2019. It is now read-only.
Add hook for extracting protocol from URLs #273
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to sanitize potentially dangerous URLs that contain executable behavior (e.g. “javascript:” URLs), we need to determine the protocol. Unfortunately, URL parsing is notoriously error-prone, so we want to use the host environment’s native functionality such that the protocol we report is the same as what it will act upon. In this case, we expose a `protocolForURL` hook that uses a generated `<a>` element to set its `href` and check the resulting `protocol`. A Node.js implementation could fall back to using the `url` package that is included in the standard library.
tomdale
added a commit
that referenced
this pull request
Jan 31, 2015
Add hook for extracting protocol from URLs
|
👍 |
|
Will release shortly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to sanitize potentially dangerous URLs that contain executable
behavior (e.g. “javascript:” URLs), we need to determine the protocol.
Unfortunately, URL parsing is notoriously error-prone, so we want to use
the host environment’s native functionality such that the protocol we
report is the same as what it will act upon.
In this case, we expose a
protocolForURLhook that uses a generated<a>element to set itshrefand check the resultingprotocol. ANode.js implementation could fall back to using the
urlpackage thatis included in the standard library.