Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead view code #10412

Merged
merged 1 commit into from
Feb 12, 2015
Merged

Remove dead view code #10412

merged 1 commit into from
Feb 12, 2015

Conversation

ebryn
Copy link
Member

@ebryn ebryn commented Feb 10, 2015

@mmun @rwjblue @krisselden Seems to have been killed with the renderer work

@ebryn ebryn force-pushed the dead-view-code branch 2 times, most recently from 0d33beb to d218c7f Compare February 10, 2015 08:28
@ebryn ebryn changed the title Remove dead view mutations code Remove dead view code Feb 10, 2015
mixonic added a commit that referenced this pull request Feb 12, 2015
@mixonic mixonic merged commit f067a37 into emberjs:master Feb 12, 2015
@teddyzeenny
Copy link
Contributor

View.addMutationListener is for the inspector. (We're using it to detect changes to the view tree)

@trek
Copy link
Member

trek commented Feb 13, 2015

I've reverted. @teddyzeenny can you PR some comments and/or move this to a place that better indicates its use by the inspector?

@teddyzeenny
Copy link
Contributor

Thanks @trek. I will add some comments. Reverting this removes the error, but I don't think it's enough since the actual triggering of the mutation event has been removed in a previous commit (so the view tree will not auto-update). I have some free time tomorrow, I can investigate.

@teddyzeenny
Copy link
Contributor

I looked into this today, we can use the "Render Performance Tab" instrumentation to detect changes to the view tree. I will remove the dependency and we can delete this code after we release a new inspector version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants