Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove dead view code" #10450

Merged
merged 1 commit into from
Feb 13, 2015
Merged

Revert "Remove dead view code" #10450

merged 1 commit into from
Feb 13, 2015

Conversation

trek
Copy link
Member

@trek trek commented Feb 13, 2015

Reverts #10412

trek added a commit that referenced this pull request Feb 13, 2015
@trek trek merged commit 3f3b952 into master Feb 13, 2015
@rwjblue
Copy link
Member

rwjblue commented Feb 13, 2015

I'm ok with it, but would like to understand the reason for reverting.

@rwjblue rwjblue deleted the revert-10412-dead-view-code branch February 13, 2015 14:45
@ebryn
Copy link
Member

ebryn commented Feb 13, 2015

yes, please do explain... it must be for _classStringForProperty?

@trek
Copy link
Member Author

trek commented Feb 14, 2015

These bits were used by Ember Inspector and canary was spitting errors for people. @teddyzeenny has more info on #10412

@rwjblue
Copy link
Member

rwjblue commented Feb 15, 2015

Pulled into beta branch, should be included in 1.11.0-beta.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants