[BUGFIX beta] remove internal uses of Ember.String.fmt #10861
Conversation
| function fmt(str, formats) { | ||
| //Ember.deprecate('Use of Ember.String.fmt() is deprecated. Use ES6 template strings instead: https://babeljs.io/docs/learn-es6/#template-strings'); | ||
| Ember.warn(strFmtDeprecationWarning); |
There was a problem hiding this comment.
Should be a deprecation not a warning, and all usage within Ember should be replaced with template strings.
There was a problem hiding this comment.
Yeah, I figured that should be the case. I changed it to Ember.deprecate and tried to chase it down (mostly just searching for fmt in packages) but I just don't know enough about Ember or the code base to track it down. Could you or someone walk me through some of the failing tests? (Currently sitting at 23 tests on my local browser QUnit)
justinwoo
force-pushed
the
deprecate-ember-string-fmt
branch
4 times, most recently
from
c058211 to
29e5e4e
Compare
|
:) We should double check tomorrow at the team meeting, but I believe this will be without controversy |
|
|
add-on? you can monkey patch Ember using ember-cli addons? |
yes, it is likely 1 file. We can distribute as both an ember-cli addon and a global file. |
|
I've gotten rid of all the internal usages of String.fmt, I can rebase and get rid of the deprecation warning in here. I've only made a simple addon using blueprints... do you have any resources I should look at to get started? |
|
awesome! @justinwoo lets start with just the single file that does the polyfil. Either myself or @rwjblue or something can jump in this weekend and handle the add-on details themselves if you have trouble. |
In ES6, template strings are available so Ember.String.fmt can be deprecated. This commit removes these usages and adds a JSDoc annotation for deprecation.
justinwoo
force-pushed
the
deprecate-ember-string-fmt
branch
from
29e5e4e to
4c6e55d
Compare
justinwoo
changed the title
|
Rebased this to remove the deprecation from Ember.String.fmt, left it in JSDoc though. Did I do this correctly? https://github.com/justinwoo/ember-deprecated-string-fmt |
|
@stefanpenner this seems like a quick win for us to land, I expect someone on the cli team could champion its completion on that end. I'm a little confused by the idea that the deprecation is in an addon. I though the pattern for these was deprecate in Ember, create an addon that silences the deprecation. I'll leave it to your discretion though. |
|
would be great to get this in this week, so it makes the 2.0 cut. @cibernox i suspect you are busy, but are you able to provide guidance / help here? |
|
@stefanpenner when you say "needs to become and addon" I would like to kindly suggest "needs to become an addon, that includes global dist" |
Nothing prevents an add-on from becoming globalized as such I do not believe the globalized dist is a blocker for extraction. The globalization can happen at a later date without issue. Maybe a globalization task force, such as yourself can champion that effort. As mentioned before, it someone creates an addon blueprint that does that today, we can use that. Otherwise it will be applied retroactively, as time permits. |
|
I do not think we have the time to remove for 2.0.0, but I'm happy to land this as is (internal changes removing usage of Also, Looks like this needs a rebase. |
|
I can take care of this today, very quickly if you're short of time @justinwoo |
would love that :) |
|
Replaced by #11959. |
In ES6, template strings are available so Ember.String.fmt can be
deprecated. This commit removes these usages and adds a JSDoc annotation
for deprecation.
fixes #10848
In ES6, template strings are available so Ember.String.fmt can bedeprecated. This commit warns against these usages so that they can be
safely migrated.
(I did try making this callEmber.deprecate, but too many tests fail when doing so. Would like help on this PR if that should be used instead.)