[BUGFIX beta] Remove internal use of Em.String.fmt & mark as deprecated #11959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 🍔 |
|
👍 to removing internal usage, and adding a deprecation for Ember.String.fmt for removal in 3.0.0. |
|
Merging this, to prevent crazy rebase hell again, but I'd love another PR adding a deprecation ( |
rwjblue
added a commit
that referenced
this pull request
Aug 3, 2015
[BUGFIX beta] Remove internal use of Em.String.fmt & mark as deprecated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resurrection of #10861
Basically the rebase was so complex that was faster to just do it again.
I've removed all internal usages of
fmtand documented it as@deprecated, but I haven't added any real deprecation because I wasn't sure if that was the desired thing.If you feel that we're are in time for removing this, I'll update this same PR with the deprecation warning and create another one removing the feature for good.