[BUGFIX release-1-13] Do not require _super in didRecieveAttrs.

[rwjblue]

Default framework hooks should not require that users call this._super (however, it is still a best practice).

This adds a new _internalDidReceiveAttrs hook for use internally to avoid using a didRecieveAttrs in AttrsProxy.

Fixes #11992.

[poteto]

In case anyone wants to know, it is good practice because:

@rwjblue
Imagine you have a component that includes a couple mixins or extends from a shared base class. That component may implement willDestroy, didInsertElement, etc. Later if you ever add those to your parent class or shared mixins, you will have issues if you didn't call _super. So, it is much easier to just have as a rule of thumb: "always call super for hooks". It should absolutely not be required (hence the fixes in 1.13.9), but without calling super you have a major refactoring hazard.

[ultimatemonty]

@rwjblue @poteto quick question related to this.

If I have a base component that hooks into didReceiveAttrs via Ember.on('didReceiveAttrs') and then extend that base component do I need to called this._super(); if I also hook into didReceiveAttrs in the extended component?

// base component
Ember.Component.extend({
  Ember.on('didReceiveAttrs', function() {
    // do some awesome stuff
  })
});

// extends base component
BaseComponent.extend({
  Ember.on('didReceiveAttrs', function() {
    // awesome stuff specific to this component
    // do I need to call this._super() here if I need to use the BaseComponent functionality as well?
  })
});

[poteto]

No, you only need to call super when overriding an existing method on a parent class. Using on listens for the event to be triggered, which doesn't override anything (unless the method name you give it does!)

E.g.

BaseComponent.extend({
  doStuff: Ember.on('didReceiveAttrs', function() {
    // no super call required, as `doStuff` is not a method on the parent class
  }),

  didInsertElement() {
    this._super(...arguments); // overriding an existing method on the parent class
  },

  willDestroyElement: Ember.on(/* ... */) // don't do this
});

// extends from BaseComponent
ChildComponent.extend({
  doStuff() {
    this._super(...arguments); // if you want to preserve BaseComponent's `doStuff` method
  }
});

[rwjblue]

Thank you @poteto!

[ultimatemonty]

what @rwjblue said!