Make d3-support compatible with pre-1.13.9 versions of Ember #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to emberjs/ember.js#12138 the library doesn't currently support older versions of ember
|
Looks good! Thanks! |
ming-codes
added a commit
that referenced
this pull request
Oct 22, 2015
Make d3-support compatible with pre-1.13.9 versions of Ember
|
Published as v1.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
d3-support depends on Ember BUGFIX #12138, so the library doesn't currently support older versions of ember. Even after the bugfix it is still advised to call _super in didReceiveAttrs, so I added it. This should fix it for older versions.