Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a failing test for #12212. #12215

Closed
wants to merge 1 commit into from
Closed

Added a failing test for #12212. #12215

wants to merge 1 commit into from

Conversation

workmanw
Copy link

Demonstrates issues with Ember.computed.sort used on class with multiple instances.

Obviously please don't merge this for now. I expect @stefanpenner will just cherry-pick or squash this into his fix.

…ted.sort used on class with multiple instances.
@stefanpenner
Copy link
Member

will look shortly

mmun added a commit to mmun/ember.js that referenced this pull request Feb 21, 2016
Resolves a regression in `Ember.computed.sort` that has existed since
2.0.0. The regression occurred when there were multiple instances of a
class using `Ember.computed.sort` and caused the sorted value to stop
updating.

Closes emberjs#12212.
Closes emberjs#12215.
Closes emberjs#12221.
Closes emberjs#12516.
rwjblue pushed a commit that referenced this pull request Feb 21, 2016
Resolves a regression in `Ember.computed.sort` that has existed since
2.0.0. The regression occurred when there were multiple instances of a
class using `Ember.computed.sort` and caused the sorted value to stop
updating.

Closes #12212.
Closes #12215.
Closes #12221.
Closes #12516.

(cherry picked from commit f05bd2d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants