Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Fix a regression in Ember.computed.sort #12991

Merged
merged 3 commits into from
Feb 21, 2016

Conversation

mmun
Copy link
Member

@mmun mmun commented Feb 21, 2016

Resolves a regression in Ember.computed.sort that has existed since 2.0.0. The regression occurred when there were multiple instances of a class using Ember.computed.sort and caused the sorted value to stop updating.

Closes #12212. This is the primary issue where more details can be found.
Closes #12215.
Closes #12221.
Closes #12516.

Wesley Workman and others added 3 commits February 21, 2016 00:46
Demonstrates issues with Ember.computed.sort used on class with multiple instances.
Resolves a regression in `Ember.computed.sort` that has existed since
2.0.0. The regression occurred when there were multiple instances of a
class using `Ember.computed.sort` and caused the sorted value to stop
updating.

Closes emberjs#12212.
Closes emberjs#12215.
Closes emberjs#12221.
Closes emberjs#12516.
@mmun mmun force-pushed the fix-computed-sort branch from 69a2334 to f05bd2d Compare February 21, 2016 05:52
krisselden added a commit that referenced this pull request Feb 21, 2016
[BUGFIX beta] Fix a regression in Ember.computed.sort
@krisselden krisselden merged commit 4a404de into emberjs:master Feb 21, 2016
@mmun mmun deleted the fix-computed-sort branch February 21, 2016 07:59
@workmanw
Copy link

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants