Implement Modifiers #16906
Closed
Implement Modifiers #16906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
force-pushed
the
modifiers
branch
3 times, most recently
from
165cabb to
97443bd
Compare
|
@chadhietala - Any opposition to closing for now? I think some verbiage tweaks (including hook names) will be needed for emberjs/rfcs#353 to move forward... |
|
Closing for now as we are trying to figure out if we need high level API right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements user defined Element Modifiers as specified in emberjs/rfcs#353.
Requires: glimmerjs/glimmer-vm#843