Introduce ModifierDefinitonState #843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chadhietala
force-pushed
the
modifier-class
branch
2 times, most recently
from
df35a7b to
53a1a41
Compare
chadhietala
changed the title
chadhietala
force-pushed
the
modifier-class
branch
from
53a1a41 to
4eafd2c
Compare
tomdale
requested changes
Aug 22, 2018
| @@ -6,3 +6,8 @@ export { | |||
| ComponentDefinitionState, | |||
| InternalComponentManager as ComponentManager, | |||
| } from './component/interfaces'; | |||
|
|
|||
| export { | |||
| InernalModifierManager as ModifierManager, | |||
|
|
||
| /* @internal */ | ||
| export interface ModifierDefinition { | ||
| manager: InernalModifierManager; |
| } | ||
|
|
||
| /* @internal */ | ||
| export type InernalModifierManager = ModifierManager< |
This introduces the notion of `ModifierDefinitionState`. The purpose of this state is to encapsulate values that are required for creation of the modifier. For instance the `ModifierDefinitionState` can contain the factory that backs a user defined modifier. This is not a new concept and is in fact why `ComponentDefintionState` exists. In the future there is opportunity to unify these ideas. This is the first step.
chadhietala
force-pushed
the
modifier-class
branch
from
4eafd2c to
7e56a9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the notion of
ModifierDefinitionState. The purpose of this stateis to encapsulate values that are required for creation of the modifier. For instance the
ModifierDefinitionStatecan contain the factory that backs a user defined modifier. This is not a new concept and is in fact whyComponentDefinitionStateexists.In the future there is opportunity to unify these ideas. This is the first step.