-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CLEANUP] Remove deprecated jQuery integration #19551
Conversation
will likely need a rebase? |
I had to fix a linting error, but other than that this should be ok! |
Due to some complications with 3.27's migration to use real modules (and the resulting massive number of deprecations being triggered) we are not 100% certain (yet) that 4.0 will be the version just after v3.28. In order to move ahead with v4.0 cleanup efforts (like this one), I've pushed a new branch that can serve as the target for breaking change PR's: https://github.com/emberjs/ember.js/tree/v4-cleanup. I've updated this PR to target that branch, can you rebase against that branch and push an update? Expand for an example of the commands needed for that rebase.
Those steps should be roughly what you need, but might need some tweaks based on your local repository setup (e.g. if you don't use Thank you for helping us push things forward! |
Done |
I'm not clear on where we sit with the |
@simonihmig this PR was auto-closed when v4-cleanup was merged to master. Can you re-open for us to review/merge against master? This is excellent work and I don't want to lose it. |
This removes the
Ember.$()
andthis.$()
jQuery integration, deprecated by RFC386.There is still more work to do, but I wanted to keep the scope of PRs small:
Note: as a breaking change, this should only get merged when it's clear that current
master
represents the "4.0 train" - not 100% sure if that decision has been taken already!?