RFC #0386 - Tracking for Remove jQuery by Default

[kategengler]

RFC #0386 - Remove jQuery by Default

Champion: @rwjblue

---

Expand for Instructions

All teams need to consider a merged RFC to plan any required work. Each team should comment on or edit this with links to issues for the work (or a note to the effect of "No work required").

See the README for more information
See #3 for an example

Under each team, for each repo requiring work for the RFC under that team:
### [repo name](repo url)

- [ ] (issue or pr) description, (issue or pr) link

Remove Repos that do not apply, conversely, there will probably be other repos that need work and should be added.

[Filled out from @simonihmig's Quest issue]

Ember.js Team:

ember.js

• add a (universal, non-silenceable) deprecation warning to Ember.$()
  🔒@simonihmig, PR: Add deprecation for Ember.$() ember.js#17489
• add a deprecation warning to this.$() in an Ember.Component
  🔒@simonihmig, PR: Add deprecation for this.$() in curly components ember.js#17488
• make sure user sees deprecation warning of jQuery integration itself, i.e. neither the jquery-integration optional feature flag is set to false nor @ember/jquery has been installed.
  🔒@simonihmig, PR: [INTERNAL] Improve jQuery deprecation message ember-cli/ember-cli#8399
• wrap all jQuery related code for svelte
  🔒@simonihmig, PR: Add svelte support for jQuery deprecations ember.js#17525

Removal phase (4.0)

• remove deprecated functions
• remove the jQuery specific code paths in the EventDispatcher

@ember/jquery

• Add support for Component.$()
  🔒@simonihmig, WIP PR: Add support for Component.$() as part of RFC386 ember-jquery#27
• Add jQuery-based EventDispatcher replacement
  🔒@simonihmig, WIP PR: WIP: Add jQuery-based event dispatcher as part of RFC386 ember-jquery#31
• Make import $ from 'jquery'; work
  🔒@simonihmig, PR: Add jQuery shim as part of RFC386 ember-jquery#33

@ember/test-helpers

• Add a deprecation warning to this.$() in component integration tests, based on setupRenderingTest()
  🔒@simonihmig, PR: Add deprecation for this.$ in rendering tests ember-test-helpers#543

Ember CLI Team:

ember-cli

• Update app blueprint, stage 1: Update @ember/jquery to latest version
  PR: blueprints: Update dependencies ember-cli/ember-cli#8396
• Update app blueprint, stage 2: remove jQuery
  🔒@CyrilleR, PR: Remove jQuery from app blueprint ember-cli/ember-cli#8394

ember-cli-babel

• Do not transpile import $ from 'jquery'; to Ember.$ if the right version of @ember/jquery is present
  🔒@simonihmig, PR: Avoid transpiling jquery module to Ember.$ if @ember/jquery is present ember-cli-babel#261

Ember Data Team:

ember-data

• Make ember-data work with ember-fetch
  🔒@tchak PR: [FEAT fetch] use ember-fetch instead of jQuery data#5386
• reworked fetch support in ember-data (avoid dependency on ember-fetch) [BUGFIX release] Remove ember-fetch dependency. data#6077.
• ensure ember-data's CI tests without jQuery Add a CI job for ember-release with jQuery data#5975

ember-fetch

• Provide a replacement API for jQuery's prefilter

Learning Team:

Website

• Add a deprecation guide
  🔒@simonihmig PR: Deprecation guide for jQuery removal ember-learn/deprecation-app#255
• Prepare the Octane edition to teach that jQuery is not part of the default
• Make sure that Super Rentals works without jQuery enabled
• Write a section for the Release Blog Post of Octane (when we change the blueprints)

guides-source

• remove usages of import $, this.$(), and $.ajax

ember.js

• review API documentation for usage of jQuery

ember-data

• review API documentation for usage of jQuery

Steering Committee:

No work expected

[simonihmig]

The ember-data todo can be checked off, as per emberjs/data#5900! 🎉

[rwjblue]

We reworked the fetch support in ember-data over in emberjs/data#6077.

emberjs/data#5975 is working to ensure ember-data's CI is running properly without jQuery.

[nlfurniss]

@simonihmig for remove usages of import $, this.$(), and $.ajax, this there a starting version of the docs we're targeting?

It doesn't make sense to remove jQuery mentions in v1.0.0 of the docs, but maybe starting from 3.0.0 it does?

[simonihmig]

It doesn't make sense to remove jQuery mentions in v1.0.0 of the docs, but maybe starting from 3.0.0 it does?

AFAIK docs for past versions will not be updated in general, only for the latest release, right?

Not sure what's still left to do here? I found these references of jQuery usage, but they all seem to have been fixed already.

[nlfurniss]

It doesn't make sense to remove jQuery mentions in v1.0.0 of the docs, but maybe starting from 3.0.0 it does?

AFAIK docs for past versions will not be updated in general, only for the latest release, right?

Not sure what's still left to do here? I found these references of jQuery usage, but they all seem to have been fixed already.

In that case I think the docs item can be checked off :-)

[rwjblue]

Just merged the ember-cli update to drop jQuery for ember new foo (generally slated for ember-cli@3.13 at this point).

[simonihmig]

There are now two PRs open for the corresponding points listed under "Removal phase (4.0)":

• [CLEANUP] Remove deprecated jQuery integration ember.js#19551
• [CLEANUP] Remove jQuery integration in EventDispatcher ember.js#19552

[simonihmig]

The two item under "Removal phase (4.0)" can be checked off!

PRs:

• [CLEANUP beta] Remove jQuery from build ember.js#19677
• [CLEANUP beta] Remove internal jQuery usage ember.js#19676
• [CLEANUP beta] Remove jQuery usage from ember-testing ember.js#19675
• [CLEANUP] Remove jQuery integration in EventDispatcher ember.js#19666
• [CLEANUP] Remove deprecated jQuery integration ember.js#19665