[BUGFIX beta] Correctly associate props with factory and owner in FactoryManager #20024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
changed the title
rwjblue
requested changes
Mar 16, 2022
|
Yes! Thanks for flagging those up; did not mean to include them! Updating momentarily. |
Previously, we stomped the `props` binding with an `Object.assign()`, which meant that the original empty props object would get GC'd after the end of the method and the item passed into the class created at the end of the `FactoryManager.create` call would be a *different* object, which does *not* have the factory or owner associations. Fixes #20023
chriskrycho
force-pushed
the
chriskrycho/fix-FactoryManager.create
branch
from
0b154e7
to
d79edb3
Compare
|
Fixed, @rwjblue! |
|
I've just checked and I do not think we can backport this one—not only b/c it's not a clean back port, but because it's doesn't work when I do the equivalent refactor there! It also doesn't affect the underlying issue we found in #20025, so it seems fine to me to just land it a fix on master and beta. |
chriskrycho
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we stomped the
propsbinding with anObject.assign(), which meant that the original empty props object would get GC'd after the end of the method and the item passed into the class created at the end of theFactoryManager.createcall would be a different object, which does not have the factory or owner associations.Fixes #20023
Also fixes a bunch of unnecessary type casts.