Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TYPES] Clean up types in routing and router services #20026

Merged
merged 1 commit into from
Mar 16, 2022
Merged

[TYPES] Clean up types in routing and router services #20026

merged 1 commit into from
Mar 16, 2022

Conversation

chriskrycho
Copy link
Contributor

There were a handful of unnecessary casts and assertions here, which I noticed as part of working on #20024 and #20025. This simplifies and cleans those up, and improves the internal type safety a bit as result!

There were a handful of unnecessary casts and assertions here, which I
noticed as part of working on #20024 and #20025. This simplifies and
cleans those up, and improves the internal type safety a bit as result!
@chriskrycho chriskrycho merged commit 86f8dad into emberjs:master Mar 16, 2022
@chriskrycho chriskrycho deleted the chriskrycho/small-router-types-fixes branch March 16, 2022 20:45
@chriskrycho chriskrycho added the TypeScript Work on Ember’s types label May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TypeScript Work on Ember’s types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants